fix(test): npm 12 pack JSON and doctor stale-socket flake - #257
Conversation
Route remaining raw npm pack --json parses through packOutputFromJson and replace the listen/close/writeFile stale-socket fixture with the event-ipc regular-file pattern plus a spawned dead-pid for lock claims.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
1 participant
Summary
npm pack --jsonparses (cli.test.ts,packed-native-smoke.ts) through exportedpackOutputFromJsonfromshared-pack.ts, matching PR feat(test): packed deleted-source proof level for the consumer harness (#103 stage 4) #225/fix(test): accept npm 12 pack --json in packed-consumer #248.doctor.test.tsendpoint fixtures: use the event-ipc regular-file stale socket pattern instead of listen/close/writeFile (race when Node unlinks the socket before rewrite), and replace the global pid scan infindDeadPidwith a spawned child that exits immediately.Test plan
pnpm exec rstest run packages/agent-bundle/tests/doctor.test.ts× 20 (20/20)pnpm exec rstest run packages/agent-bundle/tests/cli.test.ts(packed consumer case under npm 12.0.2)pnpm typecheckpnpm lint